[PM-14373] Introduce SecurityTask database table and repository #5025
Conversation
shane-melton
changed the title
shane-melton
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5025 +/- ##
==========================================
+ Coverage 42.58% 42.68% +0.09%
==========================================
Files 1406 1411 +5
Lines 65074 65131 +57
Branches 5962 5969 +7
==========================================
+ Hits 27715 27804 +89
+ Misses 36131 36082 -49
- Partials 1228 1245 +17 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
| @@ -0,0 +1,11 @@ | |||
| CREATE PROCEDURE [dbo].[SecurityTask_DeleteById] | |||
There was a problem hiding this comment.
❓ Is this even doable? I'd think we don't support it. I get that orgs or ciphers would cascade a delete, but we wouldn't directly delete a task.
There was a problem hiding this comment.
That's a great point, I had added the delete sproc to complete the base Repository implementation. But, you're right that we don't currently plan to support deleting a specific task at this time.
There was a problem hiding this comment.
❓ how do we plan on maintaining the SecurityTask table?
There was a problem hiding this comment.
Removed SecurityTask_DeleteById in cef36f1
@gbubemismith I believe the intention is to leave Tasks around for historical reporting so they won't be removed unless the organization. Otherwise, I imagine we could create background jobs that periodically clean up old/completed tasks if that's desired eventually.
src/Sql/Vault/dbo/Stored Procedures/SecurityTask/SecurityTask_ReadById.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Bishop <[email protected]>
Co-authored-by: Matt Bishop <[email protected]>
…arden#5025) * [PM-14373] Introduce SecurityTask entity and related enums * [PM-14373] Add Dapper SecurityTask repository * [PM-14373] Introduce MSSQL table, view, and stored procedures * [PM-14373] Add EF SecurityTask repository and type configurations * [PM-14373] Add EF Migration * [PM-14373] Add integration tests * [PM-14373] Formatting * Typo Co-authored-by: Matt Bishop <[email protected]> * Typo Co-authored-by: Matt Bishop <[email protected]> * [PM-14373] Remove DeleteById sproc * [PM-14373] SQL formatting --------- Co-authored-by: Matt Bishop <[email protected]>
…arden#5025) * [PM-14373] Introduce SecurityTask entity and related enums * [PM-14373] Add Dapper SecurityTask repository * [PM-14373] Introduce MSSQL table, view, and stored procedures * [PM-14373] Add EF SecurityTask repository and type configurations * [PM-14373] Add EF Migration * [PM-14373] Add integration tests * [PM-14373] Formatting * Typo Co-authored-by: Matt Bishop <[email protected]> * Typo Co-authored-by: Matt Bishop <[email protected]> * [PM-14373] Remove DeleteById sproc * [PM-14373] SQL formatting --------- Co-authored-by: Matt Bishop <[email protected]>
🎟️ Tracking
PM-14373
📔 Objective
Introduce the new
SecurityTaskentity and initial repositories.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes